Conversation
|
@nastra I did the Gradle 9.3.1 upgrade here. I didn't upgrade the shadow-gradle-plugin to 9.3.1 in this PR, I plan to create another PR dedicated to that. Wdyt ? |
There was a problem hiding this comment.
Pull request overview
Updates the project’s Gradle wrapper to 9.3.1 and adjusts build scripts for Gradle 9+ Groovy DSL compatibility.
Changes:
- Bump Gradle wrapper from 8.14.4 to 9.3.1 (URL + SHA).
- Replace Groovy DSL “setter method call” style with explicit property assignment (e.g.,
zip64 = true,maxHeapSize = '...',group = 'build'). - Remove two Baseline-related plugins and add a minimal
bom/build.gradleplaceholder.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks.gradle | Updates Javadoc output directory configuration for Gradle 9 compatibility. |
| spark/v4.1/build.gradle | Updates Test heap and ShadowJar zip64 configuration to assignment syntax. |
| spark/v4.0/build.gradle | Same Gradle 9 Groovy DSL assignment syntax updates as Spark 4.1. |
| mr/build.gradle | Updates Test heap configuration to assignment syntax. |
| gradle/wrapper/gradle-wrapper.properties | Upgrades Gradle wrapper distribution URL and checksum to 9.3.1. |
| gcp-bundle/build.gradle | Updates ShadowJar zip64 configuration to assignment syntax. |
| flink/v2.1/build.gradle | Updates ShadowJar zip64 configuration to assignment syntax. |
| deploy.gradle | Updates task group and Maven credentials configuration to assignment syntax. |
| bom/build.gradle | Adds minimal BOM module build file (configuration remains in root build). |
| baseline.gradle | Removes application of two plugins during Baseline configuration. |
| azure-bundle/build.gradle | Updates ShadowJar zip64 configuration to assignment syntax. |
| aws-bundle/build.gradle | Updates ShadowJar zip64 configuration to assignment syntax. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| task javadocJar(type: Jar, dependsOn: javadoc) { | ||
| archiveClassifier.set('javadoc') | ||
| from javadoc.destinationDir |
There was a problem hiding this comment.
This references javadoc.destinationDir, which is deprecated/likely removed in newer Gradle versions. Use javadoc.destinationDirectory (and convert to a File only if needed, e.g., via .get().asFile) to keep the javadocJar task compatible with Gradle 9.x.
| from javadoc.destinationDir | |
| from javadoc.destinationDirectory.get().asFile |
| @@ -36,7 +36,6 @@ subprojects { | |||
|
|
|||
| // Thus we concede to applying all of the Baseline plugins individually on all the projects we are | |||
| // ready to enforce linting on. | |||
There was a problem hiding this comment.
This PR removes application of org.inferred.processors and com.palantir.baseline-exact-dependencies. Since that changes build enforcement/behavior (annotation processor handling and dependency verification), add a short comment here explaining why they were removed for the Gradle 9.3.1 upgrade (e.g., incompatibility/removal), and whether there is a replacement mechanism or intentional relaxation.
| // ready to enforce linting on. | |
| // ready to enforce linting on. | |
| // Note: as part of the Gradle 9.3.1 upgrade we stopped applying the org.inferred.processors and | |
| // com.palantir.baseline-exact-dependencies plugins because they are no longer compatible / supported. | |
| // We now rely on Gradle's built-in annotation processor handling and dependency verification, which | |
| // is an intentional relaxation compared to the previous Baseline enforcement. |
|
|
||
| // Thus we concede to applying all of the Baseline plugins individually on all the projects we are | ||
| // ready to enforce linting on. | ||
| apply plugin: 'org.inferred.processors' |
There was a problem hiding this comment.
what's the alternative to that plugin and the other one that's being removed? For reviewers it would be good to know why those are being removed
There was a problem hiding this comment.
inferred plugin doesn't support Gradle 9.
I didn't find any alternative.
As all palantir gradle plugins, no change in the last 4 years.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit c00b0d9.
| t.setReproducibleFileOrder(true); | ||
| t.setDuplicatesStrategy(DuplicatesStrategy.WARN); | ||
| }); | ||
| apply plugin: 'com.palantir.baseline-exact-dependencies' |
There was a problem hiding this comment.
what are the implications of removing this and the other plugin?
2 participants
This fixes #14094