[fix] nightly pypi build for pyiceberg_core#983
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Feb 21, 2025
Merged
Conversation
kevinjqliu
force-pushed
the
kevinjqliu/fix-nightly
branch
from
f5332c2 to
88e922a
Compare
kevinjqliu
changed the title
pyiceberg_core
Fokko
approved these changes
Feb 21, 2025
Contributor
Author
|
Thank you @Fokko! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #948
I found a bug in the nightly pypi build where the version timestamp changes within the jobs, causing a single run to push multiple versions.
This PR fixes the issue by setting the version timestamp once for the entire workflow and then pass it down to individual jobs. This should ensure a consistency version
Workflow run: https://github.com/apache/iceberg-rust/actions/runs/13460497360
Testpypi: https://test.pypi.org/project/pyiceberg-core-kevinliu/#history
Tested on my fork:
Worfklow run: https://github.com/kevinjqliu/iceberg-rust/actions/runs/13461643730
Testpypi on my fork: https://test.pypi.org/project/pyiceberg-core-kevinliu/0.4.0.dev20250221170617/#files