fix (datafusion) IcebergWriteExec emits incorrect schema - #2975
Merged
Conversation
NoahKusaba
changed the title
anoopj
reviewed
Aug 10, 2026
anoopj
left a comment
anoopj
left a comment
Member
There was a problem hiding this comment.
We are using conventional commit titles. You may want to change the PR title to:
fix(datafusion): IcebergWriteExec emits incorrect schema
ie no space after fix and need a colon
| pub fn new(table: Table, input: Arc<dyn ExecutionPlan>, schema: ArrowSchemaRef) -> Self { | ||
| let plan_properties = Self::compute_properties(&input, schema); | ||
| pub fn new(table: Table, input: Arc<dyn ExecutionPlan>) -> Self { | ||
| let plan_properties = Self::compute_properties(&input, Self::make_result_schema()); |
Member
There was a problem hiding this comment.
Can we just remove the schema from compute_properties?
blackmwk
approved these changes
Aug 11, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @NoahKusaba for this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Note that this is a API breaking change. We can keep the schema parameter as a dummy-value if that is a concern.
What changes are included in this PR?
Remove schema parameter from creating a new IcebergWriteExec and use
Self::make_result_schema()
for compute_properties
Tests
test_iceberg_write_exec_advertises_result_schema -> Asserts that IcebergWriteExec returns
&ArrowSchema::new(vec![Field::new(DATA_FILES_COL_NAME, DataType::Utf8, false)])
AI Disclosure
Helped identify the bug and write the test.