perf(reader): Avoid second create_parquet_record_batch_stream_builder() call for migrated tables#2176
Open
mbutrovich wants to merge 10 commits intoapache:mainfrom
Open
perf(reader): Avoid second create_parquet_record_batch_stream_builder() call for migrated tables#2176mbutrovich wants to merge 10 commits intoapache:mainfrom
create_parquet_record_batch_stream_builder() call for migrated tables#2176mbutrovich wants to merge 10 commits intoapache:mainfrom
Conversation
mbutrovich
changed the title
create_parquet_record_batch_stream_builder() call for migrated tables
jdockerty
approved these changes
Mar 5, 2026
Contributor
jdockerty
left a comment
jdockerty
left a comment
There was a problem hiding this comment.
This LGTM!
You'll have to wait for a more authoritative review before merging, but I thought I'd at least give this a look 😄
Some non-blocking questions below.
# Conflicts: # crates/iceberg/src/arrow/delete_file_loader.rs # crates/iceberg/src/arrow/reader.rs
Collaborator
Author
|
Re-running Iceberg Java tests via Comet at apache/datafusion-comet#3642. I ran this change previously as part of apache/datafusion-comet#3551 which has a lot of the changes discussed in #2172, but those have mostly merged/been refactored as individual PRs, so I'll run just this PR. |
14 tasks
Collaborator
Author
|
It passed all the Iceberg Java tests on Comet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Introduces
open_parquet_file(), which opens the file once and returns both theArrowFileReaderandArrowReaderMetadata. The caller inspects the metadata in-memory for field IDs, optionally rebuildsArrowReaderMetadatawith a custom schema for migrated tables, then passes the originalArrowFileReadertoParquetRecordBatchStreamBuilder::new_with_metadata(). This eliminates the redundant file open that previously occurred for migrated tables.Are these changes tested?
Existing tests. Also ran full Iceberg Java suite via Comet.