feat(ci): miri test support for CI #1611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run: cargo miri setup | ||
|
|
||
| - name: Run Miri | ||
| run: cargo miri test -- --skip test_compression_codec_zstd |
There was a problem hiding this comment.
I think we should add #[cfg(not(miri))] to the test rather skip it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
mirito detect undefined behavior. #446.What changes are included in this PR?
Adds a
miri testcall to the "ci" Github Actions workflow to detect UB.Are these changes tested?
The PR's checks shows the successful run of the miri-related action in the workflow.
Note: there was UB detected in the test
catalog::memory::catalog::tests::test_create_table_falls_back_to_namespace_location_if_table_location_is_missing@ 487484ebut I believe this to be limitations with stacked borrow checks and
crossbeam-epoch. It triggered in thedropforInnerinbase_cacheof Moka fromobject_cache.