Traces & Metrics: Scan Plan #1502
Draft
+1,136
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdd
force-pushed
the
scan-plan-instrumentation
branch
from
2a02e55 to
0a8872f
Compare
This was referenced Jul 13, 2025
…er to integ test docker stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Only commit 2a02e55 is relevant - I branched off #482 which is unmerged and so the commit for that PR shows up in here too for now.
Implements an initial set of traces and metrics on the table scan plan phase.
Approach guided by prior discussions on #482 and on monthly Iceberg-rust community sync discussion a few months ago.
Are these changes tested?
Not as of yet. Testing requires a subscriber for the traces and an exporter for the metrics. This PR will be extended to add integration tests / examples that include these, as well as demonstrations on how to import the produced metrics and traces into observability platforms (probably an example with dockerised Jaeger for visualising traces. Perhaps Prometheus and Grafana for metrics?)