Skip to content

Add support for update_table() function in Sql Catalog #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gsoundar
Copy link

  • Takes in a TableCommit object and evaluates requirements with respect to current table metadata.
  • Generates a new metadata file based on updates provided.
  • Writes the new metadata file and atomically tries to commit into the SQL database.
  • Added test for a simple append
  • More tests (needed)
    • Upgrade table version
    • Update sort order
    • Alter schema
    • Update partition spec

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

- Takes in a TableCommit object and evaluates requirements
  with respect to current table metadata.
- Generates a new metadata file based on updates provided.
- Writes the new metadata file and atomically tries
  to commit into the SQL database.
- Added test for a simple append
- More tests (needed)
  - Upgrade table version
  - Update sort order
  - Alter schema
  - Update partition spec
@kyteware
Copy link

Does this already exist in #862 ?

@gsoundar
Copy link
Author

@kyteware I didn't see the other PR. It doesn't look merged yet. How can I help to review/merge it ?

gsoundar added 2 commits May 20, 2025 09:29
Address CI error for formatting
Address CI error for formatting
Address clippy error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants