chore: introduce nightly feature flag to provide error backtrace
#1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
liurenjie1024
requested changes
May 16, 2025
There was a problem hiding this comment.
Hi, @BugenZhao IIRC, this will require unstable rust toolchain? If so, I don't think we should introduce this.
|
Is it a good idea to expose |
liurenjie1024
pushed a commit
that referenced
this pull request
May 19, 2025
Signed-off-by: xxchan <[email protected]> ## Which issue does this PR close? #1340 ## What changes are included in this PR? ## Are these changes tested? --------- Signed-off-by: xxchan <[email protected]>
xxchan
added a commit
to xxchan/iceberg-rust
that referenced
this pull request
May 19, 2025
Signed-off-by: xxchan <[email protected]> ## Which issue does this PR close? apache#1340 ## What changes are included in this PR? ## Are these changes tested? --------- Signed-off-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
In nightly toolchain, there's an unstable feature
error_generic_member_accesswhich allows accessing the error to extract additional information. A common convention is toprovideerror backtrace here.This PR introduces a new non-default feature named
nightlytoicebergcrate. When it's enabled, we will provide the backtrace if it's captured iniceberg::Error.Are these changes tested?