-
Notifications
You must be signed in to change notification settings - Fork 266
feat: Add IndexByName
and IndexById
to Namemapping
#1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonathanc-n
wants to merge
11
commits into
apache:main
Choose a base branch
from
jonathanc-n:enhance-name-mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dd1f712
feat: Support `IndexByName` and `IndexById` for Namemapping
jonathanc-n 7710dd4
Update mod.rs
jonathanc-n 283c027
fix
jonathanc-n f2a66d1
Merge branch 'main' into enhance-name-mapping
jonathanc-n 0773fd6
Merge branch 'main' into enhance-name-mapping
jonathanc-n cf0624c
fixes
jonathanc-n 7c88d7c
Merge branch 'enhance-name-mapping' of https://github.com/jonathanc-n…
jonathanc-n 29fa9a1
Merge branch 'main' into enhance-name-mapping
jonathanc-n 40d30f0
Merge branch 'main' into enhance-name-mapping
jonathanc-n 71202c8
fix
jonathanc-n b771c44
fmt
jonathanc-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use crate::spec::MappedField; | ||
|
||
/// A trait for visiting and transforming a name mapping | ||
pub trait NameMappingVisitor { | ||
/// Aggregated result of `MappedField`s | ||
type S; | ||
/// Result type for processing one `MappedField` | ||
type T; | ||
|
||
/// Handles entire `NameMapping` field | ||
fn mapping(&self, field_result: Self::S) -> Self::S; | ||
|
||
/// Takes all visited child maps and merges into one map | ||
fn fields(&self, field_results: Vec<Self::T>) -> Self::S; | ||
jonathanc-n marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/// Handles a single `MappedField` | ||
fn field(&self, field: &MappedField, field_result: Self::S) -> Self::T; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.