- 
                Notifications
    You must be signed in to change notification settings 
- Fork 338
          feat: Add basic operations for UpdateSchema
          #1172
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jonathanc-n
  wants to merge
  14
  commits into
  apache:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
jonathanc-n:schema-update
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            14 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5226602
              
                feat: Add basic APIs for `UpdateSchema`
              
              
                jonathanc-n 56c6656
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n 87cc5a7
              
                clippy
              
              
                jonathanc-n 68e5f44
              
                Merge branch 'schema-update' of https://github.com/jonathanc-n/iceber…
              
              
                jonathanc-n 4cb500f
              
                fmt
              
              
                jonathanc-n 0e4bdf0
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n c517a66
              
                fix
              
              
                jonathanc-n fc0091b
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n 141b071
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n 85e2ce7
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n ca7a13e
              
                minor fixes
              
              
                jonathanc-n 2fdcfbe
              
                Merge branch 'schema-update' of https://github.com/jonathanc-n/iceber…
              
              
                jonathanc-n 78455aa
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n 8f94090
              
                Merge branch 'main' into schema-update
              
              
                jonathanc-n File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably name it
update_schema.rsavoid confusionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is best practice to infer this from the folder name. For example codebases such as Datafusion or iceberg-rust, files named metadata are just called
metadata.rsunder different folders (ex. manifest, puffin, etc.) Unless it becomes ambiguous with other names in the same folderThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very new to rust naming convention, thanks for the context! In this case, probably
schema.rsis a better name?I'm adding a new file
update_statistics.rsunder the same folder in this PR: #1359 I'll probably rename it tostatistics.rs, wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No the folder gives context, so schema/update.rs -> updating schema. with transaction/update_statistics, there is no context given to what the file is doing if it is called statistics.rs, so update_statistics is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks for the explanation!