Skip to content

feat: Add basic operations for UpdateSchema #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: Add basic operations for UpdateSchema #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5226602
feat: Add basic APIs for `UpdateSchema`
jonathanc-n Apr 7, 2025
56c6656
Merge branch 'main' into schema-update
jonathanc-n Apr 7, 2025
87cc5a7
clippy
jonathanc-n Apr 7, 2025
68e5f44
Merge branch 'schema-update' of https://github.com/jonathanc-n/iceber…
jonathanc-n Apr 7, 2025
4cb500f
fmt
jonathanc-n Apr 7, 2025
0e4bdf0
Merge branch 'main' into schema-update
jonathanc-n May 6, 2025
c517a66
fix
jonathanc-n May 7, 2025
fc0091b
Merge branch 'main' into schema-update
jonathanc-n May 12, 2025
141b071
Merge branch 'main' into schema-update
jonathanc-n May 17, 2025
85e2ce7
Merge branch 'main' into schema-update
jonathanc-n May 20, 2025
ca7a13e
minor fixes
jonathanc-n May 20, 2025
2fdcfbe
Merge branch 'schema-update' of https://github.com/jonathanc-n/iceber…
jonathanc-n May 20, 2025
78455aa
Merge branch 'main' into schema-update
jonathanc-n May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/iceberg/src/spec/schema/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ use std::collections::{HashMap, HashSet};
use std::fmt::{Display, Formatter};
use std::sync::Arc;

mod update;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably name it update_schema.rs avoid confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is best practice to infer this from the folder name. For example codebases such as Datafusion or iceberg-rust, files named metadata are just called metadata.rs under different folders (ex. manifest, puffin, etc.) Unless it becomes ambiguous with other names in the same folder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very new to rust naming convention, thanks for the context! In this case, probably schema.rs is a better name?

I'm adding a new file update_statistics.rs under the same folder in this PR: #1359 I'll probably rename it to statistics.rs, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the folder gives context, so schema/update.rs -> updating schema. with transaction/update_statistics, there is no context given to what the file is doing if it is called statistics.rs, so update_statistics is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks for the explanation!

mod utils;
mod visitor;
pub use self::visitor::*;
Expand Down
Loading
Loading