Refactor to write APIs to default to main branch #312
Closed
kevinjqliu wants to merge 3 commits into
Closed
Conversation
Fokko
reviewed
Jan 27, 2024
| self._snapshot_id = table.new_snapshot_id() | ||
| # Since we only support the main branch for now | ||
| self._branch = branch | ||
| self._parent_snapshot_id = snapshot.snapshot_id if (snapshot := self._table.current_snapshot()) else None |
Contributor
There was a problem hiding this comment.
There is more involved than just setting the name of the branch. There we take the parent snapshot that's by default the parent of the current snapshot. The current snapshot is the HEAD of the main branch. Before adding this, I would love to see also some integration tests with Spark, and some tests that assert the snapshot-tree.
Fokko
reviewed
Jan 27, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I love the changes, but before exposing this to the public through an API, we need to make sure that the behavior is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #306 (Support writing to a branch)
First pass.
This PR
"main"/"branch"/"tag") to its corresponding constant. String literals in tests are left alone.appendandoverwriteAPI to the"main"branch and pass the variable all the way down