infra: allow rerun make install without prompt#2979
Merged
kevinjqliu merged 8 commits intoapache:mainfrom Jan 30, 2026
Merged
Conversation
rambleraptor
approved these changes
Jan 29, 2026
Contributor
rambleraptor
left a comment
There was a problem hiding this comment.
This is a fantastic change! uv sync can be a very costly operation.
...especially if you're on a containerized environment where you might have a timeout to stand up a service (yes, I ran into a situation on a different project an hour ago)
geruh
reviewed
Jan 29, 2026
20ceaf7 to
d017475
Compare
kevinjqliu
commented
Jan 29, 2026
Comment on lines
+70
to
+72
| uv sync $(PYTHON_ARG) --all-extras | ||
| @# Reinstall pyiceberg if Cython extensions (.so) are missing after `make clean` (see #2869) | ||
| @if ! find pyiceberg -name "*.so" 2>/dev/null | grep -q .; then \ |
Contributor
Author
There was a problem hiding this comment.
since uv sync is super fast, its fine to call it (potentially) twice
kevinjqliu
commented
Jan 29, 2026
| install-hooks: ## Install pre-commit hooks | ||
| install: install-uv ## Install uv, dependencies, and pre-commit hooks | ||
| uv sync $(PYTHON_ARG) --all-extras | ||
| @# Reinstall pyiceberg if Cython extensions (.so) are missing after `make clean` (see #2869) |
Contributor
Author
There was a problem hiding this comment.
@# is the syntax for comment. Using just # will have the sentence echo out when running make install
geruh
reviewed
Jan 30, 2026
| install: install-uv ## Install uv, dependencies, and pre-commit hooks | ||
| uv sync $(PYTHON_ARG) --all-extras | ||
| @# Reinstall pyiceberg if Cython extensions (.so) are missing after `make clean` (see #2869) | ||
| @if ! find pyiceberg -name "*.so" 2>/dev/null | grep -q .; then \ |
Contributor
There was a problem hiding this comment.
Makes sense can't really think of a way around this until we deprecate cython (if...)
geruh
approved these changes
Jan 30, 2026
Fokko
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR lets
uvmanage the virtual env. uv will only setup a new venv if it does not exist and sync dep only when necessary.This should make the entire
make installprocess a lot faster and easier to work withContext
I noticed running
make installwhen a.venvalready existed would show an interactive prompt:We dont need this prompt. And more crucially, claude keeps on getting stuck on this prompt 😞
Are these changes tested?
Yes running
make installrepeatedlyAre there any user-facing changes?