infra: upgrade pytest and use pytest_lazy_fixtures#2978
infra: upgrade pytest and use pytest_lazy_fixtures#2978kevinjqliu wants to merge 3 commits intoapache:mainfrom
Conversation
rambleraptor
left a comment
There was a problem hiding this comment.
Looks like a simple find and replace. Thanks for doing this!
Just for posterity: the new dependency is MIT licensed + had a release / commit within the last few months.
|
|
||
|
|
||
| @pytest.fixture( | ||
| scope="session", |
There was a problem hiding this comment.
I see scope="session" was removed from these fixtures, and the tests still pass was this not needed?
There was a problem hiding this comment.
This is removed because its references (random_table_identifier for example) is function scoped. so this needs to be function scoped too.
I think this is a new requirement from pytest-lazy-fixtures
geruh
left a comment
There was a problem hiding this comment.
Overall LGTM! Moving to tpytest-lazy-fixtures makes sense
|
thanks folks! truth me told, it was claudes idea to use |
I think is a great compromise. We could potentially still remove it in the future as shared here: but that's a big refactor as we use it pretty extensively and I haven't found the time! Thanks for all the work you do! |
Rationale for this change
Closes #2810, #393
Relates to #2743
This PR upgrades
pytestto9.0.2. In doing so, we also had to switchpytest-lazy-fixturetopytest-lazy-fixtures(notice the extra s) which is a maintained version https://github.com/dev-petrov/pytest-lazy-fixturesChanged all references of
pytest_lazyfixtureto the newpytest_lazy_fixturesAre these changes tested?
Are there any user-facing changes?