Merged
Conversation
Contributor
|
this rocks, can we add this to the integration tests too? Maybe overkill but we have that testing infra set up so might as well can probably duplicate this test and change the assert to use namespace_exists |
Contributor
Author
|
@jayceslesar I had some the same test idea before I saw your edit! I didn't duplicate the test, but I added the namespace_exists call on that existing test. |
Fokko
approved these changes
Jan 28, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Nice, thanks for picking this up @rambleraptor and thanks @jayceslesar for the review 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2969
Rationale for this change
We should make
namespace_existsavailable on every catalog.Are these changes tested?
Includes unit tests. Many catalogs have a private method doing this already. Look at all of the type exceptions being deleted!
Are there any user-facing changes?