Skip to content

Add namespace check on RestCatalog.rename_table #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2025
Merged

Add namespace check on RestCatalog.rename_table #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d29555
Add namespace check
rambleraptor Oct 7, 2025
d0c7729
NoSuchNamespaceError on rename_table
rambleraptor Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,16 @@ def rename_table(self, from_identifier: Union[str, Identifier], to_identifier: U
"source": self._split_identifier_for_json(from_identifier),
"destination": self._split_identifier_for_json(to_identifier),
}

# Ensure that namespaces exist on source and destination.
source_namespace = self._split_identifier_for_json(from_identifier)["namespace"]
if not self.namespace_exists(source_namespace):
raise NoSuchNamespaceError(f"Source namespace does not exist: {source_namespace}")

destination_namespace = self._split_identifier_for_json(to_identifier)["namespace"]
if not self.namespace_exists(destination_namespace):
raise NoSuchNamespaceError(f"Destination namespace does not exist: {destination_namespace}")

response = self._session.post(self.url(Endpoints.rename_table), json=payload)
try:
response.raise_for_status()
Expand Down
52 changes: 52 additions & 0 deletions tests/catalog/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,6 +1353,11 @@ def test_rename_table_200(rest_mock: Mocker, example_table_metadata_with_snapsho
status_code=200,
request_headers=TEST_HEADERS,
)
rest_mock.head(
f"{TEST_URI}v1/namespaces/pdames",
status_code=200,
request_headers=TEST_HEADERS,
)
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
from_identifier = ("pdames", "source")
to_identifier = ("pdames", "destination")
Expand Down Expand Up @@ -1396,6 +1401,11 @@ def test_rename_table_from_self_identifier_200(
status_code=200,
request_headers=TEST_HEADERS,
)
rest_mock.head(
f"{TEST_URI}v1/namespaces/pdames",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdames 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted it to match the others 🤣

status_code=200,
request_headers=TEST_HEADERS,
)
actual = catalog.rename_table(table.name(), to_identifier)
expected = Table(
identifier=("pdames", "destination"),
Expand All @@ -1408,6 +1418,48 @@ def test_rename_table_from_self_identifier_200(
assert actual == expected


def test_rename_table_source_namespace_does_not_exist(rest_mock: Mocker) -> None:
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
from_identifier = ("invalid", "source")
to_identifier = ("pdames", "destination")

rest_mock.head(
f"{TEST_URI}v1/namespaces/invalid",
status_code=404,
request_headers=TEST_HEADERS,
)
rest_mock.head(
f"{TEST_URI}v1/namespaces/pdames",
status_code=200,
request_headers=TEST_HEADERS,
)

with pytest.raises(NoSuchNamespaceError) as e:
catalog.rename_table(from_identifier, to_identifier)
assert "Source namespace does not exist" in str(e.value)


def test_rename_table_destination_namespace_does_not_exist(rest_mock: Mocker) -> None:
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
from_identifier = ("pdames", "source")
to_identifier = ("invalid", "destination")

rest_mock.head(
f"{TEST_URI}v1/namespaces/pdames",
status_code=200,
request_headers=TEST_HEADERS,
)
rest_mock.head(
f"{TEST_URI}v1/namespaces/invalid",
status_code=404,
request_headers=TEST_HEADERS,
)

with pytest.raises(NoSuchNamespaceError) as e:
catalog.rename_table(from_identifier, to_identifier)
assert "Destination namespace does not exist" in str(e.value)


def test_delete_table_404(rest_mock: Mocker) -> None:
rest_mock.delete(
f"{TEST_URI}v1/namespaces/example/tables/fokko",
Expand Down