-
Notifications
You must be signed in to change notification settings - Fork 371
Add tests for Partition Spec Evolution #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tests for Partition Spec Evolution #2479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left some small comments 👍🏼.
Looks like this caught a bug! Thanks @gabeiglio for fixing it in #2489. Could you try to rebase this PR? |
1306663
to
c29c29c
Compare
@kevinjqliu rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a few nit comments. Thanks for adding these tests :)
the add then remove one was a surprise to me
519522f
to
b7410ef
Compare
b7410ef
to
9384139
Compare
Rationale for this change
The Java implementation has several tests around updating Table Specs. This adds three of them to the Python Catalog Tests.
Are these changes tested?
Tests should pass.
Are there any user-facing changes?
Just tests.