Add tests for Schema Evolution on Catalogs #2478
Open
+115
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeiglio
approved these changes
Sep 21, 2025
Comment on lines
+403
to
+404
| table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column( | ||
| "col3", StringType() | ||
| ).commit() |
There was a problem hiding this comment.
small nit to format for better readability (if the linter allows it)
Suggested change
| table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column( | |
| "col3", StringType() | |
| ).commit() | |
| table.update_schema() | |
| .add_column("col1", StringType()) | |
| .add_column("col2", StringType()) | |
| .add_column( "col3", StringType()) | |
| .commit() |
There was a problem hiding this comment.
The linter deeply does not like this (even with the backslashes to make it syntactically correct)
rambleraptor
force-pushed
the
schema_update_catalog_tests
branch
from
deb1b89 to
839e774
Compare
kevinjqliu
reviewed
Sep 26, 2025
Fokko
reviewed
Sep 26, 2025
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
|
Please add a test that adds data to a schema after evolution, you will notice it doesn't pick up the latest schema: #2467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PyIceberg is missing a variety of Catalog Tests compared to the Java implementation. This adds 3 different tests for schema evolution to help match the Java library coverage.
Are these changes tested?
Tests should pass.
Are there any user-facing changes?
Just tests.