Server-side planning models #2435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
changed the title
Fokko
reviewed
Sep 11, 2025
Fokko
reviewed
Sep 11, 2025
Fokko
reviewed
Sep 11, 2025
|
Thanks for adding these @rambleraptor. I think it would be nice to:
|
|
@Fokko tests added! The tests caught a handful of Pydantic issues (thought they would've been caught at runtime...), so there's a couple changes sprinkled in the models. |
Fokko
reviewed
Sep 17, 2025
Fokko
reviewed
Sep 17, 2025
Fokko
reviewed
Sep 17, 2025
Fokko
reviewed
Sep 17, 2025
sungwy
reviewed
Oct 1, 2025
rambleraptor
force-pushed
the
server_side_planning
branch
from
6a3a9fd to
5be3e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2302
Rationale for this change
This adds the models for server-side planning. There's a lot of model-related code (the requests + responses are large!), so I'm just adding the models now. I'll add the endpoints in a separate PR.
Are these changes tested?
No tests needed, just new models.
Are there any user-facing changes?
Nothing yet, the endpoints will be in a separate PR.