Add transaction tests to catalog integration tests #2371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayceslesar
reviewed
Aug 22, 2025
tests/integration/test_catalog.py
Outdated
| with table.transaction() as transaction: | ||
| with transaction.update_schema() as update_schema: | ||
| update_schema.add_column("new_col", IntegerType()) | ||
| expected_schema = update_schema._apply() |
There was a problem hiding this comment.
this apply is just to get the new schema back?
There was a problem hiding this comment.
I would rather hardcode the schema:
- This makes the test more readabile because you can see what you're asserting against.
- There are some idea's of avoid using "private" methods in the community ;)
jayceslesar
approved these changes
Sep 18, 2025
rambleraptor
approved these changes
Sep 18, 2025
vinjai
reviewed
Sep 22, 2025
|
Impressive work @gabeiglio. This would really help in the long run. |
|
@kevinjqliu @Fokko this might have fell of the radar, wondering if you folks could review it? |
sungwy
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Thank you all for the reviews! @jayceslesar @rambleraptor @vinjai
And thanks @gabeiglio for the contribution. This is a great addition to the test suite.
Fokko
approved these changes
Oct 9, 2025
|
Thanks for working on this @gabeiglio, and thanks @vinjai, @rambleraptor, @jayceslesar and @sungwy for the review 🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding more tests to the catalog tests.