Move manifest-based planning logic into separate class #2195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
commented
Jul 10, 2025
| ) | ||
| ) | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
Only change in the move - made it static
smaheshwar-pltr
commented
Jul 10, 2025
| return project(self.row_filter) | ||
|
|
||
| @cached_property | ||
| @property |
There was a problem hiding this comment.
It's now memoized on the ManifestGroupPlanner
smaheshwar-pltr
commented
Jul 10, 2025
| options: Properties | ||
|
|
||
| def __init__( | ||
| self, io: FileIO, table_metadata: TableMetadata, row_filter: BooleanExpression, case_sensitive: bool, options: Properties |
There was a problem hiding this comment.
Ah actually I'm seeing https://github.com/apache/iceberg-python/pull/1388/files#r1913363904 so maybe we can't just do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Splitting up #2031.
Are these changes tested?
Are there any user-facing changes?