feat: validate_no_new_added_delete_files
#2176
Open
+621
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungwy
reviewed
Jul 17, 2025
There was a problem hiding this comment.
Hi @gabeiglio - thank you for working on this PR, and sorry for the delayed review!
I've just started reviewing the proposed changes, and will continue to add some more comments this week.
I think this is a great start! I've added some comments regarding the PartitionMap class by referring to the Java implementation.
gabeiglio
force-pushed
the
delete-file-index
branch
from
0c82650 to
c0c9236
Compare
|
@sungwy thanks for the review! applied the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1930
Rationale for this change
Add
_validate_no_new_delete_filesand dependencies likeDeleteFileIndex,PartitionMapthat are needed for the validationAre these changes tested?
Added test for the validation, DeleteFileIndex, and PartitionMap
Are there any user-facing changes?
No