-
Notifications
You must be signed in to change notification settings - Fork 325
Improve Docs for IRC Catalog Connection #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs for IRC Catalog Connection #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Much needed. I added a few comments. Please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @james5418. I think we're almost there! Lets group the OAuth options together and split out SigV4 as a separate AWS specific auth option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @james5418 :) |
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change [`ugi` is a Hive Catalog property](https://github.com/apache/iceberg-python/blob/e33cf5ac1adf47131d4992bdb686f0e58f4e4669/pyiceberg/catalog/hive.py#L322-L327). It was accidentally added to the REST catalog section in 5209874#diff-497e037708cc64870c6ba9372f6064a69ca1e74d65d6195dcee5a44851e8b47dR151 #2175 removed it from the REST catalog section. This PR adds `ugi` back to the Hive Catalog section <img width="666" alt="Screenshot 2025-07-08 at 7 48 41 AM" src="https://github.com/user-attachments/assets/42247bae-4dfd-4688-b4d5-a33bd94d686b" /> # Are these changes tested? # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
Rationale for this change
Closes #2096
Included examples and detailed configuration guidance to enhance clarity.
Are these changes tested?
Are there any user-facing changes?