Adding promotion for UnknownType per V3+ spec #2155
+32
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When attempting to write a PyArrow dataframe that has a
null
field corresponding to a nullable Table field, I see this error:Per the V3 spec,
UnknownType
(aspa.null()
is cast) should be promotable to any type. This change attempts to unblock situations where a DataFrame may end up having a null type for an optional field while also incorporating the V3 spec.Note: This issue is related but was based on an older version. Nonetheless, the underlying situation is still blocked.
Are these changes tested?
Yes. Added a couple of relevant unit tests. Additionally, I did a manual sanity check:
Are there any user-facing changes?
Yes, this will allow UnknownType promotion.