Skip to content

Partition statistics metadata reading #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

smaheshwar-pltr
Copy link
Contributor

@smaheshwar-pltr smaheshwar-pltr commented May 22, 2025

Closes #2034

(Will test)

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

Comment on lines +46 to +47
class PartitionStatisticsFile(IcebergBaseModel):
pass
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look quite odd 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly me - meant to subclass StatisticsCommonFields but looks like you figured that out #2146 😄

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smaheshwar-pltr thanks for working on this, it would be good to get this in for the remove orphan files operation 👍

Comment on lines +46 to +47
class PartitionStatisticsFile(IcebergBaseModel):
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaheshwar-pltr
Copy link
Contributor Author

smaheshwar-pltr commented Jun 24, 2025

Closing in favour of #2146 - thank you, @Fokko! (I didn't have time to finish this)

kevinjqliu pushed a commit that referenced this pull request Jul 8, 2025
# Rationale for this change

Took @smaheshwar-pltr's draft PR and added a test:
#2033

Cherry-picked his original work to ensure it gets attributed to the
original author.

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->

---------

Co-authored-by: Sreesh Maheshwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reading table metadata with partition statistics files
2 participants