Partition statistics metadata reading #2033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
commented
May 22, 2025
Comment on lines
+46
to
+47
| class PartitionStatisticsFile(IcebergBaseModel): | ||
| pass |
There was a problem hiding this comment.
This does look quite odd 😄
There was a problem hiding this comment.
Let's add these fields: https://iceberg.apache.org/spec/#partition-statistics
There was a problem hiding this comment.
Silly me - meant to subclass StatisticsCommonFields but looks like you figured that out #2146 😄
Fokko
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Hey @smaheshwar-pltr thanks for working on this, it would be good to get this in for the remove orphan files operation 👍
Comment on lines
+46
to
+47
| class PartitionStatisticsFile(IcebergBaseModel): | ||
| pass |
There was a problem hiding this comment.
Let's add these fields: https://iceberg.apache.org/spec/#partition-statistics
kevinjqliu
pushed a commit
that referenced
this pull request
Jul 8, 2025
# Rationale for this change Took @smaheshwar-pltr's draft PR and added a test: #2033 Cherry-picked his original work to ensure it gets attributed to the original author. # Are these changes tested? # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. --> --------- Co-authored-by: Sreesh Maheshwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2034
(Will test)
Rationale for this change
Are these changes tested?
Are there any user-facing changes?