Use Iceberg-Rust for parsing the ManifestList and Manifests #2004
+1,693
−1,272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
commented
May 14, 2025
Fokko
changed the title
|
@roeap Thanks, your patch fixed correctly passing through the |
kevinjqliu
reviewed
Jul 6, 2025
There was a problem hiding this comment.
looks like we're waiting for apache/iceberg-rust#1328 to finalize, which is dependent on apache/iceberg-rust#1482 :)
| @@ -357,7 +357,7 @@ def test_write_empty_manifest() -> None: | |||
|
|
|||
| @pytest.mark.parametrize("format_version", [1, 2]) | |||
| def test_write_manifest( | |||
| generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion | |||
| generated_manifest_file_file_v1: str, generated_manifest_file_file_v2: str, format_version: TableVersion, test_schema: Schema | |||
There was a problem hiding this comment.
nit use test_partition_spec too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This replaces the Cython implementation for reading Avro with Iceberg-Rust. This would greatly simplify the PyIceberg project since we don't have to publish Python wheels anymore.
Are these changes tested?
Are there any user-facing changes?