feat: add deletion vector compaction execution - #921
Draft
wirybeaver wants to merge 6 commits into
Draft
Conversation
wirybeaver
force-pushed
the
feature/dv-compaction-executor
branch
3 times, most recently
from
September 5, 2026 23:32
68f482c to
ab5625a
Compare
Add a snapshot-bound metadata-only planner that selects rewrite candidates by file size and deduplicated file-scoped position-delete pressure. Validate planner inputs and group candidates deterministically within partitions using target-sized groups.
wirybeaver
force-pushed
the
feature/dv-compaction-executor
branch
from
September 6, 2026 00:04
ab5625a to
55c6b56
Compare
wirybeaver
force-pushed
the
feature/dv-compaction-executor
branch
from
September 6, 2026 00:19
55c6b56 to
b3834d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompactionExecutorAPI that consumes snapshot-bound planner groups and rewrites live rows throughFileScanTaskReaderandDataWriterValidateFromSnapshot(source_snapshot_id)to prevent concurrent deletes from being resurrectedFileIO::DeleteFileas idempotent for missing paths and enforce the contract in Arrow and test implementations, allowing the executor to own output paths before creation and safely clean up failures at any writer-construction stage while retaining real deletion failures477a2ff, replay final Ticket 07 source56ed503exactly as5e0c98b, and keep executor work in one commitCloses #916.
Depends on #913, #914, #915, #918, and #919.
Test plan
cmake --build build --target data_test compaction_planner_test arrow_test -j3— passed./build/src/iceberg/test/data_test --gtest_filter='CompactionExecutor*'— 12 passed./build/src/iceberg/test/data_test— 192 passed./build/src/iceberg/test/compaction_planner_test— 18 passed./build/src/iceberg/test/arrow_test— 83 passedpre-commit run -a— all hooks passedExecutor coverage includes physical row removal, no dangling delete-manifest entries, shared Puffin safety, duplicate-plan rejection, stale-plan rejection, multi-file/multi-group atomicity, cleanup failure and retry, writer failure before creation,
OutputFile::Createfailure before materialization, failure after file creation, executor reuse, commit-state-unknown ownership, file-scoped Parquet delete removal, and upgraded-table row lineage. FileIO coverage verifies idempotent deletion of missing files for Arrow and the standard test implementation.