build: Fix various compiler warnings and uninitialized members#587
Open
Joe-Abraham wants to merge 9 commits intoapache:mainfrom
Open
build: Fix various compiler warnings and uninitialized members#587Joe-Abraham wants to merge 9 commits intoapache:mainfrom
Joe-Abraham wants to merge 9 commits intoapache:mainfrom
Conversation
wgtmac
reviewed
Mar 13, 2026
Member
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for taking this! Before proceeding, I think we need to sort out what kind of fixes are required. In addition, it would be good to enforce these warnings in the ci so we don't need to fix similar issues again.
| std::unordered_map<std::string, std::string> defaults; // required | ||
| std::unordered_map<std::string, std::string> overrides; // required | ||
| std::vector<Endpoint> endpoints; | ||
| std::unordered_map<std::string, std::string> defaults{}; // required |
Member
There was a problem hiding this comment.
Do we really need to explicitly initialize STL containers?
| std::shared_ptr<SortOrder> write_order; | ||
| std::string name = ""; // required | ||
| std::string location = ""; | ||
| std::shared_ptr<Schema> schema = nullptr; // required |
Member
There was a problem hiding this comment.
Same question here, do we actually need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes various build warnings reported during CI as part of resolving #322.
To make the review process easier, the fixes have been broken down into the following logical commits: