feat: Implement EqualityDeleteWriter for equality delete files#583
Merged
wgtmac merged 3 commits intoapache:mainfrom Mar 15, 2026
Merged
feat: Implement EqualityDeleteWriter for equality delete files#583wgtmac merged 3 commits intoapache:mainfrom
wgtmac merged 3 commits intoapache:mainfrom
Conversation
evindj
approved these changes
Mar 11, 2026
wgtmac
requested changes
Mar 13, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Note: This review was generated by Gemini.
Summary & Recommendation
- Request Changes: Address the missing
partition_spec_idlogic and add the TODO to track missing encryption support.
Implement the EqualityDeleteWriter following the same PIMPL pattern as DataWriter. The writer accepts Arrow data matching the equality delete schema (columns for the equality field values) and produces metadata with content=kEqualityDeletes, equality_ids set from options, and sort_order_id propagated from options.
- Add TODO comment for encryption key_metadata field - Populate partition_spec_id from spec in DataFile metadata - Add test assertion for partition_spec_id
wgtmac
force-pushed
the
implement-equality-delete-writer
branch
from
880ad9f to
f6913b6
Compare
wgtmac
approved these changes
Mar 15, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks @shangxinli for working on this and @evindj for reviewing it!
wgtmac
force-pushed
the
implement-equality-delete-writer
branch
from
f6913b6 to
7701457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the EqualityDeleteWriter following the same PIMPL pattern as DataWriter. The writer accepts Arrow data matching the equality delete schema (columns for the equality field values) and produces metadata with content=kEqualityDeletes, equality_ids set from options, and sort_order_id propagated from options.