refactor: use std::make_unique instead of raw new in ReaderProperties#474
Closed
shangxinli wants to merge 1 commit intoapache:mainfrom
Closed
refactor: use std::make_unique instead of raw new in ReaderProperties#474shangxinli wants to merge 1 commit intoapache:mainfrom
shangxinli wants to merge 1 commit intoapache:mainfrom
Conversation
Replace raw new with std::make_unique for better exception safety and modern C++ best practices in ReaderProperties::default_properties() and ReaderProperties::FromMap(). Using std::make_unique provides: - Better exception safety (no leak if constructor throws) - More concise and readable code - Consistent with modern C++ guidelines
shangxinli
force-pushed
the
bugfixes_new_5
branch
from
3efe475 to
e5b00d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace raw new with std::make_unique for better exception safety and modern C++ best practices in ReaderProperties::default_properties() and ReaderProperties::FromMap().
Using std::make_unique provides: