refactor: remove explicit string conversion in PartitionType#472
Closed
shangxinli wants to merge 1 commit intoapache:mainfrom
Closed
refactor: remove explicit string conversion in PartitionType#472shangxinli wants to merge 1 commit intoapache:mainfrom
shangxinli wants to merge 1 commit intoapache:mainfrom
Conversation
shangxinli
force-pushed
the
bugfixes_new_3
branch
from
a30529b to
9f450b8
Compare
Removed unnecessary explicit std::string() conversion when passing partition_field.name() to emplace_back. The SchemaField constructor accepts std::string, and the implicit conversion from string_view to std::string is cleaner and equally efficient. This simplifies the code without changing behavior or performance.
shangxinli
force-pushed
the
bugfixes_new_3
branch
from
9f450b8 to
0169d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary explicit std::string() conversion when passing partition_field.name() to emplace_back. The SchemaField constructor accepts std::string, and the implicit conversion from string_view to std::string is cleaner and equally efficient.
This simplifies the code without changing behavior or performance.