Merged
Conversation
wgtmac
force-pushed
the
manifest_group
branch
2 times, most recently
from
79f27c9 to
1635143
Compare
wgtmac
force-pushed
the
manifest_group
branch
from
1635143 to
22b3cba
Compare
WZhuo
approved these changes
Dec 30, 2025
Comment on lines
+112
to
+117
| auto old_predicate = std::move(manifest_entry_predicate_); | ||
| manifest_entry_predicate_ = [old_predicate = std::move(old_predicate), | ||
| predicate = | ||
| std::move(predicate)](const ManifestEntry& entry) { | ||
| return old_predicate(entry) && predicate(entry); | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| auto old_predicate = std::move(manifest_entry_predicate_); | |
| manifest_entry_predicate_ = [old_predicate = std::move(old_predicate), | |
| predicate = | |
| std::move(predicate)](const ManifestEntry& entry) { | |
| return old_predicate(entry) && predicate(entry); | |
| }; | |
| manifest_entry_predicate_ = [old_predicate = std::move(manifest_entry_predicate_), | |
| predicate = | |
| std::move(predicate)](const ManifestEntry& entry) { | |
| return old_predicate(entry) && predicate(entry); | |
| }; |
| std::vector<std::shared_ptr<FileScanTask>> file_tasks; | ||
| file_tasks.reserve(tasks.size()); | ||
| for (auto& task : tasks) { | ||
| file_tasks.push_back(std::static_pointer_cast<FileScanTask>(task)); |
Contributor
There was a problem hiding this comment.
Suggested change
| file_tasks.push_back(std::static_pointer_cast<FileScanTask>(task)); | |
| file_tasks.push_back(internal::checked_pointer_cast<FileScanTask>(task)); |
| ICEBERG_ASSIGN_OR_RAISE(auto manifest_evaluator, get_manifest_evaluator(spec_id)); | ||
| ICEBERG_ASSIGN_OR_RAISE(bool should_match, manifest_evaluator->Evaluate(manifest)); | ||
| if (!should_match) { | ||
| continue; // Skip this manifest because it doesn't match partition filter |
Contributor
There was a problem hiding this comment.
Suggested change
| continue; // Skip this manifest because it doesn't match partition filter | |
| // Skip this manifest because it doesn't match partition filter | |
| continue; |
gty404
approved these changes
Dec 30, 2025
zhjwpku
approved these changes
Dec 30, 2025
src/iceberg/constants.h
Outdated
| constexpr int64_t kInvalidSnapshotId = -1; | ||
| /// \brief Stand-in for the current sequence number that will be assigned when the commit | ||
| /// is successful. This is replaced when writing a manifest list by the ManifestFile | ||
| /// wrapper |
Collaborator
There was a problem hiding this comment.
nit: wrapper -> adapter, which matches the code better.
liurenjie1024
approved these changes
Dec 31, 2025
Member
Author
|
Thanks all for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.