docs(datasource): START_COMMIT is exclusive, not inclusive#18954
Draft
yihua wants to merge 4 commits into
Draft
Conversation
Spark's incremental relation filters with completion_time > START_COMMIT (start-exclusive). The config doc said >=, which contradicts both the V1 relation's findInstantsInRange (start, end] and the V2 relation's RangeType.OPEN_CLOSED default.
V1 relation (used for table version 6 source tables) interprets START_COMMIT as requested/instant time; V2 relation (table version 8+) interprets it as completion time. Both are start-exclusive.
…MMIT/END_COMMIT docs
github-actions
Bot
added
size:S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18954 +/- ##
============================================
- Coverage 68.26% 68.25% -0.01%
- Complexity 29500 29513 +13
============================================
Files 2542 2542
Lines 142618 142637 +19
Branches 17790 17789 -1
============================================
+ Hits 97352 97353 +1
- Misses 37261 37281 +20
+ Partials 8005 8003 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
The doc for
hoodie.datasource.read.begin.instanttime(config aliasSTART_COMMIT) currently statesNew data written with completion_time >= START_COMMIT are fetched out, with the example phrasedon or after. This is inconsistent with the actual implementation, which treatsSTART_COMMITas exclusive:findInstantsInRange(start, end)which is(start, end](start-exclusive). SeeInstantComparison.isInRange.RangeType.OPEN_CLOSED(start-exclusive) after31166ce6f1 fix(query): Change start commit time to be exclusive in incremental query on Spark.Summary and Changelog
Updates the
START_COMMITconfig description to use>instead of>=, and rephrases the example fromon or aftertostrictly after, matching the runtime behavior of both V1 and V2 incremental relations.Impact
Documentation only. No code behavior change.
Risk Level
none
Documentation Update
This PR is the documentation update. A companion PR will update the published configuration pages on the Hudi docs site.
Contributor's checklist