Skip to content

Fix validation of 0/8 IPv4 addresses #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschmitt merged 1 commit into from
Dec 5, 2025
Merged

Fix validation of 0/8 IPv4 addresses #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions httpcore5/src/main/java/org/apache/hc/core5/net/InetAddressUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ private InetAddressUtils() {
}

private static final String IPV4_BASIC_PATTERN_STRING =
"(([1-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){1}" + // initial first field, 1-255
"(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){2}" + // following 2 fields, 0-255 followed by .
"(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}" + // First 3 fields, 0-255, followed by .
"([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])"; // final field, 0-255

private static final Pattern IPV4_PATTERN =
Expand Down
2 changes: 1 addition & 1 deletion httpcore5/src/test/java/org/apache/hc/core5/net/TestInetAddressUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ void testValidIPv4Address() {
Assertions.assertTrue(InetAddressUtils.isIPv4("127.0.0.1"));
Assertions.assertTrue(InetAddressUtils.isIPv4("192.168.0.0"));
Assertions.assertTrue(InetAddressUtils.isIPv4("255.255.255.255"));
Assertions.assertTrue(InetAddressUtils.isIPv4("0.168.0.0"));
}

@Test
Expand All @@ -52,7 +53,6 @@ void testInvalidIPv4Address() {
Assertions.assertFalse(InetAddressUtils.isIPv4("g.ar.ba.ge"));
Assertions.assertFalse(InetAddressUtils.isIPv4("192.168.0"));
Assertions.assertFalse(InetAddressUtils.isIPv4("256.255.255.255"));
Assertions.assertFalse(InetAddressUtils.isIPv4("0.168.0.0")); //IP address that starts with zero not allowed
}

@Test
Expand Down