HTTPCORE: Add RFC 7639 ALPN header codec and constant #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Oct 2, 2025
| * @since 5.4 | ||
| */ | ||
| @Contract(threading = ThreadingBehavior.IMMUTABLE) | ||
| public final class AlpnHeader { |
Member
There was a problem hiding this comment.
@arturobernalg It is going to be a support class used in client, right? Maybe it should be called AlpnHeaderSupport and be @Internal?
Member
Author
There was a problem hiding this comment.
@ok2c I’m working on the client-side part now.
httpcore5/src/main/java/org/apache/hc/core5/http/message/AlpnHeaderSupport.java
Show resolved
Hide resolved
Add AlpnHeaderSupport codec + HttpHeaders.ALPN; canonical encoding (uppercase hex, '%' encoded).
Member
|
@arturobernalg I will commit the header constant but codecs should go into client. This feature belongs there. |
Member
Author
@ok2c I'll the proper changes and I will moved to the client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New public
AlpnHeaderimplementing RFC7639.Add HttpHeaders.ALPN. Canonical encoding: keep tchar except %; uppercase hex; UTF-8; liberal parse (OWS, lower-case %hh).
Note: A follow-up PR for httpclient5 will inject ALPN on CONNECT (classic & async) via an optional provider