Skip to content

added useLocalAuthorityResolver() to ServerBootstrap and AsyncServerBootStrap classes #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdw8j wants to merge 1 commit into from
Closed

added useLocalAuthorityResolver() to ServerBootstrap and AsyncServerBootStrap classes #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServerBootstrap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public class AsyncServerBootstrap {
private IOSessionListener sessionListener;
private Http1StreamListener streamListener;
private IOReactorMetricsListener threadPoolListener;
private boolean localAuthorityResolver;

private AsyncServerBootstrap() {
this.routeEntries = new ArrayList<>();
Expand Down Expand Up @@ -435,6 +436,16 @@ public final AsyncServerBootstrap addFilterLast(final String name, final AsyncFi
return this;
}

/**
* Create {@link RequestRouter} with LOCAL_AUTHORITY_RESOLVER (default: IGNORE_PORT_AUTHORITY_RESOLVER).
*
* @since 5.4
*/
public final AsyncServerBootstrap useLocalAuthorityResolver(final boolean localAuthorityResolver) {
this.localAuthorityResolver = localAuthorityResolver;
return this;
}

public HttpAsyncServer create() {
final String actualCanonicalHostName = canonicalHostName != null ? canonicalHostName : InetAddressUtils.getCanonicalLocalHostName();
final HttpRequestMapper<Supplier<AsyncServerExchangeHandler>> requestRouterCopy;
Expand All @@ -451,9 +462,9 @@ public HttpAsyncServer create() {
requestRouterCopy = requestRouter;
} else {
requestRouterCopy = RequestRouter.create(
new URIAuthority(actualCanonicalHostName),
this.localAuthorityResolver ? RequestRouter.LOCAL_AUTHORITY : new URIAuthority(actualCanonicalHostName),
UriPatternType.URI_PATTERN, routeEntries,
RequestRouter.IGNORE_PORT_AUTHORITY_RESOLVER,
this.localAuthorityResolver ? RequestRouter.LOCAL_AUTHORITY_RESOLVER : RequestRouter.IGNORE_PORT_AUTHORITY_RESOLVER,
requestRouter);
}
}
Expand Down
15 changes: 13 additions & 2 deletions httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/ServerBootstrap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public class ServerBootstrap {
private HttpConnectionFactory<? extends DefaultBHttpServerConnection> connectionFactory;
private ExceptionListener exceptionListener;
private Http1StreamListener streamListener;
private boolean localAuthorityResolver;

private ServerBootstrap() {
this.routeEntries = new ArrayList<>();
Expand Down Expand Up @@ -346,6 +347,16 @@ public final ServerBootstrap addFilterLast(final String name, final HttpFilterHa
return this;
}

/**
* Create {@link RequestRouter} with LOCAL_AUTHORITY_RESOLVER (default: IGNORE_PORT_AUTHORITY_RESOLVER).
Copy link
Member

@ok2c ok2c Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdw8j Please do not mention LOCAL_AUTHORITY_RESOLVER and IGNORE_PORT_AUTHORITY_RESOLVER. This is an implementation details and it should be mentioned in javadocs

*
* @since 5.4
*/
public final ServerBootstrap useLocalAuthorityResolver(final boolean localAuthorityResolver) {
Copy link
Member

@ok2c ok2c Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdw8j Please use a better name for the method. #routeToLocalAuthority for example.

this.localAuthorityResolver = localAuthorityResolver;
return this;
}

public HttpServer create() {
final String actualCanonicalHostName = canonicalHostName != null ? canonicalHostName : InetAddressUtils.getCanonicalLocalHostName();
final HttpRequestMapper<HttpRequestHandler> requestRouterCopy;
Expand All @@ -362,10 +373,10 @@ public HttpServer create() {
requestRouterCopy = requestRouter;
} else {
requestRouterCopy = RequestRouter.create(
new URIAuthority(actualCanonicalHostName),
this.localAuthorityResolver ? RequestRouter.LOCAL_AUTHORITY : new URIAuthority(actualCanonicalHostName),
UriPatternType.URI_PATTERN,
routeEntries,
RequestRouter.IGNORE_PORT_AUTHORITY_RESOLVER,
this.localAuthorityResolver ? RequestRouter.LOCAL_AUTHORITY_RESOLVER : RequestRouter.IGNORE_PORT_AUTHORITY_RESOLVER,
requestRouter);
}
}
Expand Down