Conversation
kasakrisz
marked this pull request as draft
September 21, 2026 12:59
asf-ci-hive
added
tests pending
tests failed
tests passed
and removed
tests pending
tests failed
labels
kasakrisz
marked this pull request as ready for review
September 23, 2026 09:27
deniskuzZ
reviewed
Sep 23, 2026
deniskuzZ
reviewed
Sep 23, 2026
kasakrisz
force-pushed
the
HIVE-30080-master-swo-infinite-loop
branch
from
September 24, 2026 09:12
7f566fe to
401e454
Compare
|
deniskuzZ
reviewed
Sep 24, 2026
| while (!remaining.isEmpty()) { | ||
| Operator<?> op = remaining.poll(); | ||
|
|
||
| if (excludeOps.contains(op)) { |
Member
There was a problem hiding this comment.
i would collapse 2 blocks into 1, but either ok
if (excludeOps.contains(op) || !visited.add(op)) {
continue;
}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use a visited set to track operators while traversing the Hive operator plan in
SharedWorkOptimizer.findDescendantWorkOperators.Why are the changes needed?
Hive operator plans cannot cycle if all the edges are represented by a Reduce Sink operator. However, when there are semijoin and/or DPP edges, those can reference back to a Mapper and it may create a cycle.
This can lead to an infinite loop when traversing the plan.
Does this PR introduce any user-facing change?
No.
How was this patch tested?