Skip to content

Hive 29481#6375

Open
ashniku wants to merge 2 commits intoapache:masterfrom
ashniku:HIVE-29481
Open

Hive 29481#6375
ashniku wants to merge 2 commits intoapache:masterfrom
ashniku:HIVE-29481

Conversation

@ashniku
Copy link

@ashniku ashniku commented Mar 17, 2026

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

No. This is a fix for internal directory parsing logic. Users will now see correct query results instead of encountering NumberFormatException or empty result sets when metadata collisions occur.

How was this patch tested?

@Neer393
Copy link
Contributor

Neer393 commented Mar 17, 2026

CI is failing. Please fix it for review

@VenuReddy2103
Copy link
Contributor

Have tried combinations of transactional and transactional_properties.

  1. create table tp1(a int) stored as orc TBLPROPERTIES ('transactional'='false','transactional_properties'='default'); => creates a translated external table without error.
  2. create table tp2(a int) stored as orc TBLPROPERTIES ('transactional'='false','transactional_properties'='insert_only'); => creates an insert only.
  3. create table tp3(a int) stored as orc TBLPROPERTIES ('transactional_properties'='default'); => Fails with error Cannot specify transactional_properties without transactional
  4. create table tp4(a int) stored as orc TBLPROPERTIES ('transactional_properties'='insert_only'); => Fails with error Cannot specify transactional_properties without transactional

Considering the above behavior, IMHO, we should either create a translated external table without error(like 1) OR fail with error(like 3 & 4).

@ashniku
Copy link
Author

ashniku commented Mar 18, 2026

closing the PR, I will re-open again

@ashniku ashniku closed this Mar 18, 2026
@ashniku
Copy link
Author

ashniku commented Mar 18, 2026

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants