Skip to content

HIVE-29511: [hiveACIDRepl] For incremental replication newly created UDF data count is not updated in metricCollector #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivaom02 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HIVE-29511: [hiveACIDRepl] For incremental replication newly created UDF data count is not updated in metricCollector #6372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,7 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive
Map<String, Long> metricMap = new HashMap<>();
metricMap.put(ReplUtils.MetricName.EVENTS.name(), estimatedNumEvents);
metricMap.put(ReplUtils.MetricName.TABLES.name(), 0L);
metricMap.put(ReplUtils.MetricName.FUNCTIONS.name(), 0L);
int size = tablesForBootstrap.size();
if (db != null && db.getParameters()!=null &&
Boolean.parseBoolean(db.getParameters().get(REPL_RESUME_STARTED_AFTER_FAILOVER))) {
Expand Down Expand Up @@ -1299,6 +1300,8 @@ private void dumpEvent(NotificationEvent ev, Path evRoot, Path dumpRoot, Path cm
work.getMetricCollector().reportStageProgress(getName(), ReplUtils.MetricName.EVENTS.name(), 1);
if (eventHandler.dumpType() == DumpType.EVENT_CREATE_TABLE) {
work.getMetricCollector().reportStageProgress(getName(), ReplUtils.MetricName.TABLES.name(), 1);
} else if (eventHandler.dumpType() == DumpType.EVENT_CREATE_FUNCTION) {
work.getMetricCollector().reportStageProgress(getName(), ReplUtils.MetricName.FUNCTIONS.name(), 1);
}
}
work.getReplLogger().eventLog(String.valueOf(ev.getEventId()), eventHandler.dumpType().toString());
Expand Down
2 changes: 2 additions & 0 deletions ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplStateLogWork.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ public void replStateLog() throws SemanticException {
metricCollector.reportStageProgress("REPL_LOAD", ReplUtils.MetricName.EVENTS.name(), 1);
if ("EVENT_CREATE_TABLE".equals(eventType)) {
metricCollector.reportStageProgress("REPL_LOAD", ReplUtils.MetricName.TABLES.name(), 1);
} else if ("EVENT_CREATE_FUNCTION".equals(eventType)) {
metricCollector.reportStageProgress("REPL_LOAD", ReplUtils.MetricName.FUNCTIONS.name(), 1);
}
break;
case END:
Expand Down
1 change: 1 addition & 0 deletions ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public IncrementalLoadTasksBuilder(String dbName, String loadPath, IncrementalLo
Map<String, Long> metricMap = new HashMap<>();
metricMap.put(ReplUtils.MetricName.EVENTS.name(), (long) iterator.getTotalEventsCount());
metricMap.put(ReplUtils.MetricName.TABLES.name(), 0L);
metricMap.put(ReplUtils.MetricName.FUNCTIONS.name(), 0L);
this.shouldFailover = shouldFailover;
if (shouldFailover) {
Database db = null;
Expand Down
Loading