HIVE-29293: Restrict config 'mapreduce.job.queuename' at tez session #6155
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Oct 28, 2025
There was a problem hiding this comment.
Isn't this an intentional behaviour?
hive/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 559 to 560 in 4669cd5
The Javadoc of this method even states:
/**
* This takes settings from MR and applies them to the appropriate Tez configuration. This is
* similar to what Pig on Tez does (refer MRToTezHelper.java).
*
* @param conf configuration with MR settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Verify config 'mapreduce.job.queuename' value, if tez.queue.name is null.
Why are the changes needed?
When tez.queue.name is null, setting 'mapreduce.job.queuename' creates security issue because any user can submit job to this queue. TezSessionPoolManager is currently not verifying the queue since null is being passed. This patch addresses this concern by verifying that if tez.queue.name is null, then we verify 'mapreduce.job.queuename'.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Remote cluster.