Skip to content

HIVE-29250: Display effects of PlanModifierForASTConv in EXPLAIN CBO output #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

HIVE-29250: Display effects of PlanModifierForASTConv in EXPLAIN CBO output #6118

merged 2 commits into from
Nov 7, 2025
+3,226 −2,984

Conversation

@zabetak
Copy link
Member

@zabetak zabetak commented Oct 7, 2025

What changes were proposed in this pull request?

  1. Extract PlanModifierForASTConv outside of ASTConverter and apply it explicitly in CalcitePlanner
  2. Inline getOptimizedAST since now it becomes a trivial call
  3. Remove unused variant of getOptimizedAST

Why are the changes needed?

  1. Display all PlanModifierForASTConv effects in EXPLAIN CBO output
  2. Improve diagnosability by getting the final CBO plan with all transformations

Does this PR introduce any user-facing change?

The output of EXPLAIN CBO changes slightly but there is no effect in correctness/performance cause the plan remains the same.

How was this patch tested?

Existing tests

@zabetak zabetak marked this pull request as ready for review October 8, 2025 17:00
thomasrebele
thomasrebele approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@thomasrebele thomasrebele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (non-binding)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Passed Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zabetak zabetak merged commit 6b5febc into apache:master Nov 7, 2025
2 checks passed
@zabetak zabetak deleted the HIVE-29250 branch November 7, 2025 18:12
@zabetak
Copy link
Member Author

zabetak commented Nov 7, 2025

Many thanks for the reviews @thomasrebele and @kasakrisz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kasakrisz kasakrisz kasakrisz approved these changes

+1 more reviewer

@thomasrebele thomasrebele thomasrebele approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zabetak @thomasrebele @kasakrisz @asf-ci-hive