report dirty metadata in meta table #81
Open
+217
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
requested changes
Aug 16, 2021
There was a problem hiding this comment.
Thanks for submitting this PR, @Mengqi777 ! I have a few remarks made on part of the code. Additional to those, please add UTs for each of the added methods.
Also, we need to add description for this new command at hbck2 README.md.
| @@ -263,6 +259,39 @@ public static void addRegionToMeta(Connection conn, RegionInfo region) throws IO | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
| /** | |||
| * List all dirty metadata currently in META. | |||
There was a problem hiding this comment.
Let's explain properly what "dirty" means in this context.
| Scan scan = new Scan(); | ||
| ResultScanner resultScanner = metaTable.getScanner(scan); | ||
| for (Result result : resultScanner) { | ||
| result.listCells().forEach(cell -> { |
There was a problem hiding this comment.
Do we really need to iterate through each cell? It seems you only care about the row key, so no need to go through every single cell of each row.
| @@ -100,6 +102,7 @@ | |||
| private static final String SET_REGION_STATE = "setRegionState"; | |||
| private static final String SCHEDULE_RECOVERIES = "scheduleRecoveries"; | |||
| private static final String GENERATE_TABLE_INFO = "generateMissingTableDescriptorFile"; | |||
| private static final String REPORT_DIRTY_METADATA = "reportDirtyMetadata"; | |||
There was a problem hiding this comment.
Let's give this command a more intuitive name. What's dirtyMetadata?
| writer.println(" Options:"); | ||
| writer.println(" -f, --fix fix meta by delete all dirty metadata found."); | ||
| writer.println(" Looks for undeleted metadata in meta table. "); | ||
| writer.println(" Undeleted metadata means a table has been deleted, but not delete all metadata in meta."); |
There was a problem hiding this comment.
Can we describe here in more details an example scenario where this command would be useful? See, for example, the explanation for reportMissingRegionsInMeta.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@wchevreuil hi bro, thanks for your suggestion, I have change the name to reportundeletedregionsinmeta and add the UTs, PTAL. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cluster has experienced such problems： a table has been deleted but meta table still storage metadata about this table, thoese metadata show in hbck ui until I delete them.