Skip to content

fix tqdm: Fix progress bar to 100% on successful execution#1570

Open
ArnavBalyan wants to merge 2 commits intoapache:mainfrom
ArnavBalyan:arnavb/tqdm-overrides-845
Open

fix tqdm: Fix progress bar to 100% on successful execution#1570
ArnavBalyan wants to merge 2 commits intoapache:mainfrom
ArnavBalyan:arnavb/tqdm-overrides-845

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

Changes

  • Fixes TDQM hook with overrides #845. The h_tqdm.ProgressBar adapter never reached 100% when overrides were passed to .execute() because override nodes are counted in the bar's total but do not trigger run_after_node_execution,
    leaving the bar short of total on a successful run.
  • On a successful graph execution we top up progress_bar.n to progress_bar.total inside run_after_graph_execution.. On failure we leave the partial count visible.

How I tested this

  • UT

Notes

  • N/A

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@ArnavBalyan
Copy link
Copy Markdown
Member Author

cc @skrawcz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TDQM hook with overrides

1 participant