Skip to content

Conversation

@MikaelSmith
Copy link
Contributor

Description of PR

On SLES 15, failing to add tirpc results in failures linking pthreads. tirpc is present and appears to be the newer RPC library option (with support for IPv6), and provides an rpc.h that Hadoop falsely thinks comes from SunRPC. Use tirpc when available.

How was this patch tested?

Tested builds on RedHat 8 and 9; SLES 15; and Ubuntu 20.04, 22.04, and 24.04.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

On SLES 15, failing to add tirpc results in failures linking pthreads.
tirpc is present and appears to be the newer RPC library option (with
support for IPv6), and provides an rpc.h that Hadoop falsely thinks
comes from SunRPC. Use tirpc when available.

Tested on RedHat 8 and 9; SLES 15; and Ubuntu 20.04, 22.04, and 24.04.
@MikaelSmith
Copy link
Contributor Author

I'm not sure what would be a good way to test this. We have functional integration tests on all platforms using Hadoop, but the hadoop-pipes tool in particular looks pretty standalone and doesn't have any unit tests.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 31m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 54m 2s trunk passed
+1 💚 compile 0m 58s trunk passed
+1 💚 mvnsite 0m 56s trunk passed
+1 💚 shadedclient 97m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 28s the patch passed
+1 💚 compile 0m 34s the patch passed
+1 💚 cc 0m 34s the patch passed
+1 💚 javac 0m 34s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 29s the patch passed
+1 💚 shadedclient 41m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 42s hadoop-pipes in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
175m 34s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8060/1/artifact/out/Dockerfile
GITHUB PR #8060
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname Linux f0392362f71b 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 506be4e
Default Java Red Hat, Inc.-1.8.0_472-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8060/1/testReport/
Max. process+thread count 618 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-pipes U: hadoop-tools/hadoop-pipes
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8060/1/console
versions git=2.43.7 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants