Skip to content

Conversation

@dmmkr
Copy link
Contributor

@dmmkr dmmkr commented Nov 5, 2025

Description of PR

filter() method inside the ClientJerseyRetryFilter class, calls checkUrlConnectivity() in a while loop, If there is any issue with connectivity, it decrements the leftRetries till it becomes 0 and throws an Exception, but if it succeeds it keeps on spinning inside the infinite while loop, so added a return after checkUrlConnectivity().

After fixing the above issue, the yarn logs command was throwing below error.

Can not find any log file matching the pattern: [ALL] for the container: container_id within the application: app_id

The XML response of /ws/v1/node/containers/<container_id>/logs is

Screenshot from 2025-11-05 19-27-47

So in getContainerLogFiles(), an additional getJSONObject("containerLogsInfoes") has been added to ensure the XML response is parsed properly

How was this patch tested?

Validated yarn logs -applicationId for running and completed applications.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 0s trunk passed
+1 💚 compile 0m 19s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 20s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 checkstyle 0m 17s trunk passed
+1 💚 mvnsite 0m 21s trunk passed
+1 💚 javadoc 0m 22s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 21s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
-1 ❌ spotbugs 0m 40s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-warnings.html hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client in trunk has 81 extant spotbugs warnings.
+1 💚 shadedclient 14m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 16s the patch passed
+1 💚 compile 0m 14s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 14s the patch passed
+1 💚 compile 0m 14s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 9s the patch passed
+1 💚 mvnsite 0m 16s the patch passed
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 13s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 spotbugs 0m 35s the patch passed
+1 💚 shadedclient 14m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 24m 33s hadoop-yarn-client in the patch passed.
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
83m 9s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8057/1/artifact/out/Dockerfile
GITHUB PR #8057
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 7beca2f726c0 5.15.0-153-generic #163-Ubuntu SMP Thu Aug 7 16:37:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6ff9576
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8057/1/testReport/
Max. process+thread count 634 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8057/1/console
versions git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@dmmkr
Copy link
Contributor Author

dmmkr commented Nov 6, 2025

@slfan1989 Could you please review the changes?
Thanks!

@slfan1989
Copy link
Contributor

@dmmkr Thank you for your contribution! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants