Skip to content

HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade. #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+199 −49
Open

HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade. #8053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c46c6af
HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version…
zhtttylz Oct 30, 2025
14115d7
CI: trigger SpotBugs (no-op)
zhtttylz Oct 31, 2025
7b27c79
include the directory-maven-plugin to compute repo.root
zhtttylz Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions dev-support/findbugs-exclude-global.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter>
<Match>
<Bug category="EXPERIMENTAL"/>
</Match>
<Match>
<Bug code="AT"/>
</Match>
<Match>
<Bug code="CT"/>
</Match>
<Match>
<Bug code="EI"/>
</Match>
<Match>
<Bug code="EI2"/>
</Match>
<Match>
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
</Match>
<Match>
<Bug pattern="NN_NAKED_NOTIFY"/>
</Match>
</FindBugsFilter>
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-cos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-huaweicloud/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-tos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
6 changes: 5 additions & 1 deletion hadoop-common-project/hadoop-auth/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,11 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-common-project/hadoop-kms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,12 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-common-project/hadoop-minikdc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,12 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-common-project/hadoop-nfs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,12 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down
7 changes: 6 additions & 1 deletion hadoop-common-project/hadoop-registry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${project.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${project.basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,11 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down Expand Up @@ -402,7 +406,7 @@
</plugins>
</build>
</profile>

<profile>
<id>dist</id>
<activation>
Expand Down
1 change: 1 addition & 0 deletions ...lient/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
* <li>standard deviation of i/o rate </li>
* </ul>
*/
// CI: trigger SpotBugs (no-op)
public class TestDFSIO implements Tool {
// Constants
private static final Logger LOG = LoggerFactory.getLogger(TestDFSIO.class);
Expand Down
10 changes: 7 additions & 3 deletions hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,19 @@
</exclusions>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down Expand Up @@ -328,7 +332,7 @@
</build>
</profile>
</profiles>

<modules>
<module>hadoop-mapreduce-client-core</module>
<module>hadoop-mapreduce-client-common</module>
Expand Down
9 changes: 7 additions & 2 deletions hadoop-mapreduce-project/hadoop-mapreduce-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
<scope>test</scope>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
Expand All @@ -165,7 +165,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.examples.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${mr.examples.basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
6 changes: 5 additions & 1 deletion hadoop-mapreduce-project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${mr.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
5 changes: 4 additions & 1 deletion hadoop-project-dist/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml</excludeFilterFile>
</excludeFilterFiles>
<maxHeap>2048</maxHeap>
</configuration>
</plugin>
Expand Down
17 changes: 17 additions & 0 deletions hadoop-project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,6 +2598,23 @@
<groupId>com.google.code.maven-replacer-plugin</groupId>
<artifactId>replacer</artifactId>
</plugin>
<plugin>
<groupId>org.commonjava.maven.plugins</groupId>
<artifactId>directory-maven-plugin</artifactId>
<version>1.0</version>
<executions>
<execution>
<id>calc-repo-root</id>
<goals>
<goal>highest-basedir</goal>
</goals>
<phase>initialize</phase>
<configuration>
<property>repo.root</property>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
8 changes: 6 additions & 2 deletions hadoop-tools/hadoop-aliyun/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
11 changes: 8 additions & 3 deletions hadoop-tools/hadoop-archive-logs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,14 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>
${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>
${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>
${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-tools/hadoop-aws/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
18 changes: 11 additions & 7 deletions hadoop-tools/hadoop-azure/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,25 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<!-- To run with the default Sun ruleset,
<!-- To run with the default Sun ruleset,
comment out the configLocation line -->
<configLocation>src/config/checkstyle.xml</configLocation>
<suppressionsLocation>src/config/checkstyle-suppressions.xml</suppressionsLocation>
</configuration>

</plugin>

<plugin>
Expand Down Expand Up @@ -150,13 +154,13 @@
<scope>provided</scope>
</dependency>


<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<scope>compile</scope>
</dependency>

<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-storage</artifactId>
Expand Down Expand Up @@ -220,7 +224,7 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>

<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-mapreduce-client-jobclient</artifactId>
Expand Down
6 changes: 5 additions & 1 deletion hadoop-tools/hadoop-benchmark/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/src/main/findbugs/exclude.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/src/main/findbugs/exclude.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
<plugin>
Expand Down
Loading