Skip to content

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Jul 23, 2025

Description of PR

JIRA: HADOOP-19617 - [JDK17] Remove JUnit4 Dependency - Tools.

This PR aims to remove the JUnit4 dependency from the tools module, and has been successfully compiled locally. The removal of the hadoop-azure module will be handled in hadoop-azure Part 3.

How was this patch tested?

Junit Test.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@slfan1989 slfan1989 marked this pull request as ready for review August 2, 2025 03:34
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 9m 19s Maven dependency ordering for branch
+1 💚 mvninstall 19m 50s trunk passed
+1 💚 compile 0m 55s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 47s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 30s trunk passed
+1 💚 mvnsite 6m 40s trunk passed
+1 💚 javadoc 6m 17s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 8s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 8m 45s trunk passed
+1 💚 shadedclient 21m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 4m 34s the patch passed
+1 💚 compile 0m 53s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 53s the patch passed
+1 💚 compile 0m 42s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 42s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 25s the patch passed
+1 💚 mvnsite 4m 55s the patch passed
+1 💚 javadoc 4m 35s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 4m 31s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 9m 58s the patch passed
+1 💚 shadedclient 20m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 26m 14s hadoop-distcp in the patch passed.
+1 💚 unit 2m 9s hadoop-federation-balance in the patch passed.
+1 💚 unit 6m 7s hadoop-streaming in the patch passed.
+1 💚 unit 0m 50s hadoop-dynamometer-workload in the patch passed.
+1 💚 unit 0m 21s hadoop-dynamometer-infra in the patch passed.
+1 💚 unit 0m 38s hadoop-dynamometer-blockgen in the patch passed.
+1 💚 unit 1m 3s hadoop-archives in the patch passed.
+1 💚 unit 0m 48s hadoop-archive-logs in the patch passed.
+1 💚 unit 0m 25s hadoop-rumen in the patch passed.
-1 ❌ unit 33m 10s /patch-unit-hadoop-tools_hadoop-gridmix.txt hadoop-gridmix in the patch passed.
+1 💚 unit 0m 34s hadoop-datajoin in the patch passed.
+1 💚 unit 0m 53s hadoop-extras in the patch passed.
+1 💚 unit 0m 24s hadoop-kafka in the patch passed.
+1 💚 unit 0m 22s hadoop-aliyun in the patch passed.
+1 💚 unit 11m 54s hadoop-sls in the patch passed.
+1 💚 unit 0m 35s hadoop-resourceestimator in the patch passed.
+1 💚 unit 0m 57s hadoop-azure-datalake in the patch passed.
+1 💚 unit 0m 30s hadoop-fs2img in the patch passed.
+1 💚 unit 3m 32s hadoop-compat-bench in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
228m 30s
Reason Tests
Failed junit tests hadoop.mapred.gridmix.TestSleepJob
hadoop.mapred.gridmix.TestGridmixSubmission
hadoop.mapred.gridmix.TestLoadJob
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/2/artifact/out/Dockerfile
GITHUB PR #7823
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux a14b8b653f1c 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6f278a0
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/2/testReport/
Max. process+thread count 1052 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-distcp hadoop-tools/hadoop-federation-balance hadoop-tools/hadoop-streaming hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-blockgen hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-kafka hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-azure-datalake hadoop-tools/hadoop-fs2img hadoop-tools/hadoop-compat-bench U: hadoop-tools
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 7m 49s Maven dependency ordering for branch
+1 💚 mvninstall 19m 24s trunk passed
+1 💚 compile 1m 33s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 44s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 46s trunk passed
+1 💚 mvnsite 6m 43s trunk passed
+1 💚 javadoc 6m 15s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 1s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 8m 52s trunk passed
+1 💚 shadedclient 20m 47s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 53s Maven dependency ordering for patch
+1 💚 mvninstall 4m 27s the patch passed
+1 💚 compile 0m 52s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 52s the patch passed
+1 💚 compile 0m 41s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 mvnsite 4m 52s the patch passed
+1 💚 javadoc 4m 35s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 4m 28s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 10m 5s the patch passed
+1 💚 shadedclient 20m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 26m 25s hadoop-distcp in the patch passed.
+1 💚 unit 2m 15s hadoop-federation-balance in the patch passed.
+1 💚 unit 6m 6s hadoop-streaming in the patch passed.
+1 💚 unit 0m 55s hadoop-dynamometer-workload in the patch passed.
+1 💚 unit 0m 20s hadoop-dynamometer-infra in the patch passed.
+1 💚 unit 0m 39s hadoop-dynamometer-blockgen in the patch passed.
+1 💚 unit 1m 2s hadoop-archives in the patch passed.
+1 💚 unit 0m 47s hadoop-archive-logs in the patch passed.
+1 💚 unit 0m 25s hadoop-rumen in the patch passed.
+1 💚 unit 14m 24s hadoop-gridmix in the patch passed.
+1 💚 unit 0m 32s hadoop-datajoin in the patch passed.
+1 💚 unit 0m 50s hadoop-extras in the patch passed.
+1 💚 unit 0m 24s hadoop-kafka in the patch passed.
+1 💚 unit 0m 20s hadoop-aliyun in the patch passed.
+1 💚 unit 11m 52s hadoop-sls in the patch passed.
+1 💚 unit 0m 36s hadoop-resourceestimator in the patch passed.
+1 💚 unit 0m 55s hadoop-azure-datalake in the patch passed.
+1 💚 unit 0m 28s hadoop-fs2img in the patch passed.
+1 💚 unit 3m 34s hadoop-compat-bench in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
208m 47s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/3/artifact/out/Dockerfile
GITHUB PR #7823
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 1f94140e2012 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 90676f8
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/3/testReport/
Max. process+thread count 1029 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-distcp hadoop-tools/hadoop-federation-balance hadoop-tools/hadoop-streaming hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-blockgen hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-kafka hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-azure-datalake hadoop-tools/hadoop-fs2img hadoop-tools/hadoop-compat-bench U: hadoop-tools
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7823/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor Author

@Hexiaoqiao Could you please help review this PR? Thank you very much!

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @slfan1989 !

@slfan1989 slfan1989 merged commit 744088a into apache:trunk Aug 6, 2025
4 checks passed
@slfan1989
Copy link
Contributor Author

@cnauroth Thanks for the review! I am merging this PR into the trunk branch to continue advancing other JDK 17 upgrade-related work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants