Skip to content

HADOOP-19259. Upgrade to jackson 2.14.3 (#7428) #7622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pjfanning
Copy link
Contributor

This upgrades Jackson to 2.14.3

as a side effect this changes two javax dependencies

-removes javax.ws.rs:jsr311-api:1.1.1
-adds javax.xml.bind:jaxb-api:2.3.1

Contributed by PJ Fanning

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 1m 41s Maven dependency ordering for branch
+1 💚 mvninstall 20m 11s branch-3.4 passed
+1 💚 compile 8m 29s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 7m 38s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 2m 1s branch-3.4 passed
+1 💚 mvnsite 9m 52s branch-3.4 passed
+1 💚 javadoc 4m 47s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 4m 48s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+0 🆗 spotbugs 0m 14s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 16m 57s /branch-spotbugs-root-warnings.html root in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 20m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 27s /patch-mvninstall-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvninstall 0m 22s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ mvninstall 0m 39s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 40s /patch-compile-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt root in the patch failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.
-1 ❌ javac 0m 40s /patch-compile-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt root in the patch failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.
-1 ❌ compile 0m 38s /patch-compile-root-jdkPrivateBuild-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06.
-1 ❌ javac 0m 38s /patch-compile-root-jdkPrivateBuild-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 45s /results-checkstyle-root.txt root: The patch generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84)
-1 ❌ mvnsite 6m 0s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 4m 36s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 4m 47s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+0 🆗 spotbugs 0m 15s hadoop-project has no data from spotbugs
-1 ❌ spotbugs 0m 32s /patch-spotbugs-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ spotbugs 0m 29s /patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-client in the patch failed.
-1 ❌ spotbugs 1m 2s /patch-spotbugs-root.txt root in the patch failed.
-1 ❌ shadedclient 1m 34s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 4m 47s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
131m 43s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/1/artifact/out/Dockerfile
GITHUB PR #7622
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname Linux 67332f06fe85 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 1ed933b
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/1/testReport/
Max. process+thread count 552 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

This upgrades Jackson to 2.14.3

as a side effect this changes two javax dependencies

-removes javax.ws.rs:jsr311-api:1.1.1
-adds javax.xml.bind:jaxb-api:2.3.1

Contributed by PJ Fanning
@pjfanning pjfanning force-pushed the HADOOP-19259-backport branch from 566a0bf to 3fc36ac Compare April 21, 2025 11:28
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 1m 35s Maven dependency ordering for branch
+1 💚 mvninstall 20m 10s branch-3.4 passed
+1 💚 compile 8m 33s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 7m 45s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 2m 0s branch-3.4 passed
+1 💚 mvnsite 12m 55s branch-3.4 passed
+1 💚 javadoc 4m 45s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 4m 49s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+0 🆗 spotbugs 0m 14s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 17m 17s /branch-spotbugs-root-warnings.html root in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 20m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 17m 37s the patch passed
+1 💚 compile 8m 20s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 8m 20s the patch passed
+1 💚 compile 7m 45s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 7m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 58s the patch passed
+1 💚 mvnsite 11m 20s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 4m 40s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 4m 52s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+0 🆗 spotbugs 0m 14s hadoop-project has no data from spotbugs
+1 💚 shadedclient 35m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 606m 48s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
809m 38s
Reason Tests
Failed junit tests hadoop.yarn.api.records.timeline.TestTimelineRecords
hadoop.yarn.util.timeline.TestShortenedFlowName
hadoop.yarn.api.records.timelineservice.TestTimelineServiceRecords
hadoop.yarn.applications.distributedshell.TestDSTimelineV10
hadoop.yarn.applications.distributedshell.TestDSTimelineV20
hadoop.yarn.applications.distributedshell.TestDSWithMultipleNodeManager
hadoop.yarn.applications.distributedshell.TestDSTimelineV15
hadoop.yarn.client.api.impl.TestYarnClient
hadoop.yarn.client.api.impl.TestYarnClientImpl
hadoop.yarn.client.TestApplicationMasterServiceProtocolForTimelineV2
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown
hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain
hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun
hadoop.yarn.server.timelineservice.TestTimelineServiceClientIntegration
hadoop.yarn.server.TestMiniYarnCluster
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
hadoop.yarn.server.timelineservice.documentstore.TestDocumentStoreTimelineReaderImpl
hadoop.yarn.server.timelineservice.documentstore.TestDocumentStoreTimelineWriterImpl
hadoop.yarn.server.timelineservice.documentstore.collection.TestDocumentOperations
hadoop.yarn.server.timelineservice.documentstore.writer.cosmosdb.TestCosmosDBDocumentStoreWriter
hadoop.yarn.server.timelineservice.documentstore.reader.cosmosdb.TestCosmosDBDocumentStoreReader
hadoop.yarn.server.timelineservice.collector.TestNMTimelineCollectorManager
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderServer
hadoop.yarn.server.timelineservice.storage.TestFileSystemTimelineWriterImpl
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesACL
hadoop.yarn.server.timelineservice.reader.TestTimelineUIDConverter
hadoop.yarn.server.timelineservice.collector.TestTimelineCollector
hadoop.yarn.server.timelineservice.storage.TestFileSystemTimelineReaderImpl
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServices
hadoop.yarn.server.timelineservice.collector.TestPerNodeTimelineCollectorsAuxService
hadoop.yarn.server.nodemanager.webapp.TestNMWebServices
hadoop.yarn.server.nodemanager.containermanager.TestContainerManagerRecovery
hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisherForV2
hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
hadoop.yarn.server.resourcemanager.TestRMRestart
hadoop.yarn.server.resourcemanager.TestRMHATimelineCollectors
hadoop.yarn.server.resourcemanager.TestResourceTrackerService
hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher
hadoop.yarn.server.timeline.webapp.TestTimelineWebServicesWithSSL
hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilterForV1
hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer
hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebApp
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.mapred.TestMRTimelineEventHandling
hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler
Subsystem Report/Notes
Docker ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/3/artifact/out/Dockerfile
GITHUB PR #7622
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname Linux 8fd0255532ec 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 3fc36ac
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/3/testReport/
Max. process+thread count 5373 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7622/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Contributor Author

@steveloughran this PR causes multiple test failures in 3.4 branch. This change needs the switch to Jersey 2 and that does not seem to have been backported to the 3.4 branch.

@pjfanning pjfanning closed this Apr 22, 2025
@steveloughran
Copy link
Contributor

ok

@pjfanning pjfanning deleted the HADOOP-19259-backport branch April 24, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants