HADOOP-19433. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-extras. #7586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
cnauroth
reviewed
Apr 11, 2025
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
@cnauroth Thank you for reviewing the code. Apologies for not noticing your comment earlier, as I was focused on upgrading other modules to JUnit 5. I believe your suggestion is correct, and I have made the necessary changes. However, I noticed that the unit tests are still being executed. I suspect this may be related to the fact that we are still in a mixed testing mode using both JUnit 4 and JUnit 5. |
74 tasks
jojochuang
reviewed
Apr 28, 2025
|
|
||
| /** | ||
| * Tests for the MR implementation of {@link GetGroups} | ||
| */ | ||
| @Ignore | ||
| @Disabled |
There was a problem hiding this comment.
The test was disabled 14 years ago (https://issues.apache.org/jira/browse/MAPREDUCE-3860)
Maybe we should just remove it.... just saying.
There was a problem hiding this comment.
@jojochuang Thank you very much for helping review the code! I agree to remove this class.
@cnauroth Do you agree with doing this? This is indeed an old unit test and is marked as Ignore.
There was a problem hiding this comment.
LOL, good point. I'm fine with removing it.
There was a problem hiding this comment.
I have deleted this class and am waiting for the result of yetus.
| @@ -52,4 +53,33 @@ protected Tool getTool(PrintStream o) { | |||
| return new GetGroups(conf, o); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Just curious. Are these test method overrides necessary?
There was a problem hiding this comment.
Nvm just noticed your comments above!
There was a problem hiding this comment.
@jojochuang Thank you for your suggestion. In my opinion, there's no need to override. Your suggestion is good, and we can remove this class.
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth @jojochuang Could you please review this PR again? Thank you very much! |
|
@cnauroth @jojochuang Could you help review this PR? Thank you very much! |
cnauroth
approved these changes
May 14, 2025
|
@cnauroth Thank you very much for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19433. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-extras.
How was this patch tested?
mvn clean test & Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?