HADOOP-19401: Improve error message when OS can't identify the current user. #7325
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I think we're stuck with string matching logic on this. There isn't a more specific exception type to detect. The |
|
Pre-submit will give this a -1 for no new tests. I don't see a good way to write a unit test for it. It would probably end up relying on things like Docker or elevated permissions that aren't guaranteed to be in place on everyone's CI hosts. |
|
💔 -1 overall
This message was automatically generated. |
|
+1 |
slfan1989
approved these changes
Jan 26, 2025
asfgit
pushed a commit
that referenced
this pull request
Jan 26, 2025
…t user. Closes #7325 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Steve Loughran <[email protected]> Signed-off-by: Ayush Saxena <[email protected]> (cherry picked from commit b6916eb)
asfgit
pushed a commit
that referenced
this pull request
Jan 26, 2025
…t user. Closes #7325 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Steve Loughran <[email protected]> Signed-off-by: Ayush Saxena <[email protected]> (cherry picked from commit b6916eb) (cherry picked from commit 7d699e5)
|
I committed this to trunk, branch-3.4 and branch-3.3. @slfan1989 , @steveloughran , @ayushtkn , thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Under simple auth, UGI identifies the current Hadoop user as the OS user. If the OS can't determine the user, then they receive a cryptic
KerberosAuthException, even though Kerberos auth isn't really configured. I've seen this come up for Hadoop processes launched in Docker containers that accidentally specify a UID that's not actually present in the image. We can improve this error so that users have a better understanding of how to fix the problem.Here is how the Unix user identification flows through the JDK:
https://github.com/openjdk/jdk11u-dev/blob/master/src/jdk.security.auth/share/classes/com/sun/security/auth/UnixPrincipal.java#L65
https://github.com/openjdk/jdk11u-dev/blob/master/src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixLoginModule.java#L129
https://github.com/openjdk/jdk11u-dev/blob/master/src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java#L55
Ultimately, this is just delegating to native syscalls to
getuidandgetpwuid:https://github.com/openjdk/jdk11u-dev/blob/master/src/jdk.security.auth/unix/native/libjaas/Unix.c#L82
How was this patch tested?
One easy way to reproduce this problem is to exec inside the dev container with a non-existent UID:
Then, run UGI's main entry point:
This is problematic for two reasons:
NullPointerExceptionfrom the JDK doesn't point the user toward how to fix the problem.KerberosAuthExceptionactually misleads people into thinking it's a Kerberos problem, even though this is simple auth.After the patch, the error indicates a problem with the UID and avoids mentioning Kerberos. This will point users in the right direction of looking at problems with their OS user.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?