YARN-11754. [JDK17] Fix SpotBugs Issues in YARN.

[slfan1989]

Description of PR

JIRA: YARN-11754. [JDK17] Fix SpotBugs Issues in YARN.

I am following up on the upgrade to JDK 17 and have found some SpotBugs issues in YARN. I will address these issues in this JIRA, with the fixes being relatively minor.

Performance Warnings

Code | Warning
-- | --
Bx | Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnRWHelper.readResultsWithTimestamps(Result, byte[], byte[], KeyConverter, ValueConverter, boolean)
  | Bug type BX_UNBOXING_IMMEDIATELY_REBOXED (click for details)In class org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnRWHelperIn method org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnRWHelper.readResultsWithTimestamps(Result, byte[], byte[], KeyConverter, ValueConverter, boolean)Called method Long.valueOf(long)At ColumnRWHelper.java:[line 333]

Dodgy code Warnings

Code | Warning
-- | --
RCN | Redundant nullcheck of it, which is known to be non-null in org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
  | Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details)In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationServiceIn method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)Value loaded from itReturn value of org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService$LocalResourceTrackerState.getCompletedResourcesIterator() of type org.apache.hadoop.yarn.server.nodemanager.recovery.RecoveryIteratorRedundant null check at ResourceLocalizationService.java:[line 344]
RCN | Redundant nullcheck of it, which is known to be non-null in org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
  | Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details)In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationServiceIn method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)Value loaded from itReturn value of org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService$LocalResourceTrackerState.getStartedResourcesIterator() of type org.apache.hadoop.yarn.server.nodemanager.recovery.RecoveryIteratorRedundant null check at ResourceLocalizationService.java:[line 357]

Code	Warning
RCN	Redundant nullcheck of it, which is known to be non-null in org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
[Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details)](https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/804/artifact/out/branch-spotbugs-hadoop-yarn-project-warnings.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService
In method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
Value loaded from it
Return value of org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService$LocalResourceTrackerState.getCompletedResourcesIterator() of type org.apache.hadoop.yarn.server.nodemanager.recovery.RecoveryIterator
Redundant null check at ResourceLocalizationService.java:[line 344]

RCN	Redundant nullcheck of it, which is known to be non-null in org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
[Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details)](https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/804/artifact/out/branch-spotbugs-hadoop-yarn-project-warnings.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService
In method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.recoverTrackerResources(LocalResourcesTracker, NMStateStoreService$LocalResourceTrackerState)
Value loaded from it
Return value of org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService$LocalResourceTrackerState.getStartedResourcesIterator() of type org.apache.hadoop.yarn.server.nodemanager.recovery.RecoveryIterator
Redundant null check at ResourceLocalizationService.java:[line 357]

How was this patch tested?

No unit tests are required.

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	6m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	18m 34s		trunk passed
+1 💚	compile	1m 19s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	1m 12s		trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚	checkstyle	0m 38s		trunk passed
+1 💚	mvnsite	0m 44s		trunk passed
+1 💚	javadoc	0m 48s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 44s		trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚	spotbugs	1m 24s		trunk passed
+1 💚	shadedclient	19m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 36s		the patch passed
+1 💚	compile	1m 14s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	1m 14s		the patch passed
+1 💚	compile	1m 4s		the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚	javac	1m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 33s		the patch passed
+1 💚	mvnsite	0m 38s		the patch passed
+1 💚	javadoc	0m 35s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚	spotbugs	1m 25s		the patch passed
+1 💚	shadedclient	19m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 57s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	unit	0m 24s		hadoop-yarn-server-timelineservice-hbase-client in the patch passed.
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		81m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7317/1/artifact/out/Dockerfile
GITHUB PR	#7317
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 8f89d5f3925e 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / d2de4fd
Default Java	Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7317/1/testReport/
Max. process+thread count	562 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7317/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[cnauroth]

+1

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

From my perspective, no additional tests required, as this is more like a style cleanup.

Thanks for patching this, @slfan1989 !

[slfan1989]

@cnauroth Thank you very much for helping review the code! We made the changes because the Apache Hadoop QBT Report: trunk+JDK11 on Linux/x86_64 gave us some spotBugs warnings, and I think it's better to fix them.

https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/805/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn-warnings.html [16K]
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/805/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-warnings.html [16K]
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/805/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-warnings.html [8.0K]
h

I will also submit a PR to fix the HDFS spotBugs issue. Please help review the code later. Thanks again!

[slfan1989]

@cnauroth Thank you very much for the review!